Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start adding types #1160

Merged
merged 86 commits into from
Jan 8, 2024
Merged

Start adding types #1160

merged 86 commits into from
Jan 8, 2024

Conversation

gjmooney
Copy link
Contributor

No description provided.

martinRenou
martinRenou reviewed Dec 22, 2023
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! 🚀 Thanks

js/src/controls/Control.ts Outdated Show resolved Hide resolved
js/src/controls/Control.ts Outdated Show resolved Hide resolved
martinRenou
martinRenou reviewed Jan 3, 2024
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice work!! Thanks!

js/src/Map.ts Outdated Show resolved Hide resolved
js/src/Map.ts Outdated Show resolved Hide resolved
js/src/Map.ts Outdated Show resolved Hide resolved
js/src/Map.ts Outdated Show resolved Hide resolved
js/src/Map.ts Show resolved Hide resolved
js/src/Map.ts Outdated Show resolved Hide resolved
js/src/Map.ts Outdated Show resolved Hide resolved
js/src/Map.ts Outdated Show resolved Hide resolved
js/src/controls/Control.ts Show resolved Hide resolved
martinRenou
martinRenou requested changes Jan 5, 2024
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more comments and I think we're good to go! Thanks!

js/src/leaflet.ts Show resolved Hide resolved
js/src/leaflet-imageservice.ts Outdated Show resolved Hide resolved
js/src/layers/MagnifyingGlass.ts Outdated Show resolved Hide resolved
js/src/extension.ts Outdated Show resolved Hide resolved
js/src/amd-public-path.ts Outdated Show resolved Hide resolved
@martinRenou martinRenou marked this pull request as ready for review January 8, 2024 10:38
martinRenou
martinRenou approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this huge work!

@martinRenou martinRenou merged commit 3baddd0 into jupyter-widgets:master Jan 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gjmooney @martinRenou